Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support the ability to make the MenuItem component a clickable link #17788

Open
1 task done
AbrahamLara opened this issue Oct 17, 2024 · 4 comments
Open
1 task done

Comments

@AbrahamLara
Copy link

AbrahamLara commented Oct 17, 2024

The problem

I am implementing a feature for a chat bot that allows developers to add custom elements to the chat header. The custom elements are a link, menu (w/submenus), and buttons.

Even if the web chat is a larger size, there is only so much you can fit into the chat header. This is where the Menu component is useful for a developer who wants to fit more elements in the chat header that can't all be displayed at once.

The problem at the moment is that developers will be able to add Menus with custom buttons and submenus that can't fit in the header, but they won't be able to add links to menus because the MenuItem component doesn't support anchor element attributes as props (href, target, etc.).

Image

The solution

I would like for the MenuItem component to support anchor element attributes so that it can be a link in order to help complete the feature I'm working on.

Examples

Application/PAL

No response

Business priority

Medium Priority = upcoming release but is not pressing

Available extra resources

No response

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@alina-jacob
Copy link
Member

alina-jacob commented Oct 21, 2024

Adding the relevant Slack thread 1 and thread 2, shared by Taylor for context!

@adamalston
Copy link
Contributor

I think I'm encountering the same issue as the issue author except I can define an href. I just can't add target or rel attributes without getting errors since they aren't typed. If I ignore the errors, the attributes work fine.

Reproduction for the target and rel issues: https://stackblitz.com/edit/github-9smbll?file=src%2FApp.tsx. I think just adding types will resolve the issue since there's already a rest parameter in the code:

@aagonzales
Copy link
Member

Summary from the Slack threads: Yes, this is an enhancement we want to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later 🧊
Development

No branches or pull requests

4 participants