Merge branch 'main' into tests

carbon-design-system · Nov 19, 2024 · ed87938 · ed87938
2 parents f3db1bc + 5b3ad47
commit ed87938
Show file tree

Hide file tree

Showing 11 changed files with 37 additions and 55 deletions.
diff --git a/.github/workflows/metrics-merge-rate.yml b/.github/workflows/metrics-merge-rate.yml
@@ -46,7 +46,7 @@ jobs:
           echo "- **Merge Rate**: $MERGE_RATE%" >> $GITHUB_STEP_SUMMARY
 
       - name: Send message to Slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {

diff --git a/.github/workflows/slack-announcement.yml b/.github/workflows/slack-announcement.yml
@@ -37,7 +37,7 @@ jobs:
     steps:
       - name: Send slack announcement
         id: slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {

diff --git a/.github/workflows/slack-build-notifications.yml b/.github/workflows/slack-build-notifications.yml
@@ -24,7 +24,7 @@ jobs:
     steps:
       - name: Send custom JSON data to Slack
         id: slack-success
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {
@@ -42,7 +42,7 @@ jobs:
     steps:
       - name: Send custom JSON data to Slack
         id: slack-failure
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {

diff --git a/.github/workflows/slack-office-hours-design.yml b/.github/workflows/slack-office-hours-design.yml
@@ -13,7 +13,7 @@ jobs:
     steps:
       - name: Send custom JSON data to Slack workflow
         id: slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {

diff --git a/.github/workflows/slack-office-hours-dev.yml b/.github/workflows/slack-office-hours-dev.yml
@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Send custom JSON data to Slack workflow
         id: slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {
@@ -105,7 +105,7 @@ jobs:
     steps:
       - name: Send custom JSON data to Slack workflow
         id: slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {
@@ -198,7 +198,7 @@ jobs:
     steps:
       - name: Send custom JSON data to Slack workflow
         id: slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
+        uses: slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3 # v1.27.1
         with:
           payload: |
             {

diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -6987,9 +6987,7 @@ Map {
         "type": "string",
       },
       "light": [Function],
-      "name": Object {
-        "type": "string",
-      },
+      "name": [Function],
       "onChange": Object {
         "type": "func",
       },
@@ -7011,20 +7009,7 @@ Map {
       "title": Object {
         "type": "string",
       },
-      "value": Object {
-        "args": Array [
-          Array [
-            Object {
-              "type": "string",
-            },
-            Object {
-              "type": "number",
-            },
-          ],
-        ],
-        "isRequired": true,
-        "type": "oneOfType",
-      },
+      "value": [Function],
     },
     "render": [Function],
   },

diff --git a/packages/react/src/components/Tile/Tile-test.js b/packages/react/src/components/Tile/Tile-test.js
@@ -111,12 +111,7 @@ describe('Tile', () => {
       const onClick = jest.fn();
       render(
         <div role="group" aria-label="selectable tiles">
-          <SelectableTile
-            disabled
-            id="tile-1"
-            name="tiles"
-            onClick={onClick}
-            value="value">
+          <SelectableTile disabled id="tile-1" onClick={onClick}>
             <span role="img" aria-label="vertical traffic light">
               🚦
             </span>
@@ -130,25 +125,13 @@ describe('Tile', () => {
     it('should cycle elements in document tab order', async () => {
       render(
         <div role="group" aria-label="selectable tiles">
-          <SelectableTile
-            data-testid="element"
-            id="tile-1"
-            name="tiles"
-            value="value">
+          <SelectableTile data-testid="element" id="tile-1">
             tile 1
           </SelectableTile>
-          <SelectableTile
-            data-testid="element"
-            id="tile-2"
-            name="tiles"
-            value="value">
+          <SelectableTile data-testid="element" id="tile-2">
             tile 2
           </SelectableTile>
-          <SelectableTile
-            data-testid="element"
-            id="tile-3"
-            name="tiles"
-            value="value">
+          <SelectableTile data-testid="element" id="tile-3">
             tile 3
           </SelectableTile>
         </div>
@@ -180,11 +163,7 @@ describe('Tile', () => {
 
     it('should respect slug prop', () => {
       render(
-        <SelectableTile
-          slug={<AILabel />}
-          id="tile-1"
-          name="tiles"
-          value="value">
+        <SelectableTile slug={<AILabel />} id="tile-1">
           Default tile
         </SelectableTile>
       );
@@ -440,7 +419,7 @@ describe('Tile', () => {
 
   it('respect selected prop', async () => {
     const { container } = render(
-      <SelectableTile id="selectable-tile-1" selected value={'test'}>
+      <SelectableTile id="selectable-tile-1" selected>
         Option 1
       </SelectableTile>
     );

diff --git a/packages/react/src/components/Tile/Tile.tsx b/packages/react/src/components/Tile/Tile.tsx
@@ -561,7 +561,10 @@ SelectableTile.propTypes = {
    * The `name` of the `<input>`.
    * @deprecated
    */
-  name: PropTypes.string,
+  name: deprecate(
+    PropTypes.string,
+    'The `name` property is no longer used.  It will be removed in the next major release.'
+  ),
 
   /**
    * The empty handler of the `<input>`.
@@ -602,7 +605,10 @@ SelectableTile.propTypes = {
    * The value of the `<input>`.
    * @deprecated
    */
-  value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
+  value: deprecate(
+    PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+    'The `value` property is no longer used.  It will be removed in the next major release.`'
+  ),
 };
 
 export interface ExpandableTileProps extends HTMLAttributes<HTMLDivElement> {

diff --git a/packages/styles/scss/components/list-box/_list-box.scss b/packages/styles/scss/components/list-box/_list-box.scss
@@ -99,6 +99,10 @@ $list-box-menu-width: convert.to-rem(300px);
     }
   }
 
+  .#{$prefix}--multi-select.#{$prefix}--multi-select--readonly.#{$prefix}--list-box {
+    cursor: default;
+  }
+
   .#{$prefix}--list-box--lg {
     block-size: convert.to-rem(48px);
     max-block-size: convert.to-rem(48px);

diff --git a/packages/styles/scss/components/multiselect/_multiselect.scss b/packages/styles/scss/components/multiselect/_multiselect.scss
@@ -201,7 +201,7 @@
 
   .#{$prefix}--multi-select.#{$prefix}--multi-select--readonly
     .#{$prefix}--tag--filter {
-    box-shadow: 0 0 0 1px $background-inverse;
+    box-shadow: 0 0 0 1px $border-subtle;
   }
 
   .#{$prefix}--multi-select.#{$prefix}--multi-select--readonly

diff --git a/packages/styles/scss/components/tag/_tag.scss b/packages/styles/scss/components/tag/_tag.scss
@@ -246,6 +246,14 @@
     );
   }
 
+  .#{$prefix}--multi-select--readonly
+    .#{$prefix}--tag--high-contrast:not(.#{$prefix}--tag--operational)
+    .#{$prefix}--tag__close-icon {
+    &:hover {
+      background-color: transparent;
+    }
+  }
+
   .#{$prefix}--tag--outline:not(.#{$prefix}--tag--operational):not(span):not(
       [disabled]
     ) {