-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Content Design Guild] Modal component topic is missing content #4234
Comments
@sstrubberg @laurenmrice @aagonzales |
Issue refinement
Separate issueA separate issue would need to be created to tackle the following: 1. Live demo changes
We would need to connect with dev to make sure we could alter the text of these react stories that show up in the live demo dropdown, since the names would then be different than the ones on the actual storybook. I think it is probably doable though.
All of the Live demo modal example content changes need to be addressed in a dev issue in the carbon repo to fix this in the storybook first, and then it will fix the live demo on the website. It would be good to have all of the content that you would want to change in each of the examples finalized before posting them in the dev issue. The changes to the story names in the live demo dropdown could also be addressed in this same issue. |
Here is the updated Word doc that will be used to make changes to the Modal component. |
Made additional small changes where appropriate and added them to this Word doc. |
Updated content as outlined in this issue: carbon-design-system#4234
Updated the Modal component page in my own fork and created a pull request: |
Updated content as outlined in this issue: carbon-design-system#4234
* Update usage.mdx Updated content as outlined in this issue: #4234 * Update src/pages/components/modal/usage.mdx Fixing my overzealous application of IBM Style :) Co-authored-by: Anna Gonzales <[email protected]> * Update src/pages/components/modal/usage.mdx Co-authored-by: Anna Gonzales <[email protected]> * Update src/pages/components/modal/usage.mdx Co-authored-by: Anna Gonzales <[email protected]> * Update usage.mdx Addressing comments from the pull request. * chore: format --------- Co-authored-by: Anna Gonzales <[email protected]> Co-authored-by: emyarod <[email protected]>
https://carbondesignsystem.com/components/modal/usage/
Need explicit guidance for creating content for modals.
The text was updated successfully, but these errors were encountered: