Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mdx-components): add footer and common js for ibm compliance #1775

Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat(mdx-components): add footer and common js for ibm compliance #1775

merged 1 commit into from
Feb 28, 2024

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Feb 22, 2024 •
edited
Loading

Closes carbon-design-system/carbon#15637
Closes carbon-design-system/carbon#15652

Changelog

New

  • manager-head.html with IBM Footer and common js + basic carbon css added

Testing / reviewing

run mdx-components storybook and verify footer is displaying correctly and common.js is being loaded

@alisonjoseph alisonjoseph requested a review from a team as a code owner February 22, 2024 19:40
@carbon-bot
Copy link
Contributor

❗ The commits in this PR will result in the following version changes:

🌟 MINOR release: @carbon-platform/mdx-components

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alisonjoseph
Copy link
Member Author

@jdharvey-ibm any idea why this is failing, does it matter for this storybook update? 😅

@jharvey10
Copy link
Contributor

@jdharvey-ibm any idea why this is failing, does it matter for this storybook update? 😅

@alisonjoseph LOL this is the age old "static build hit the GH rate limit" issue. But yeah, you're right that for the storybook update, we can safely ignore this.

@andreancardona
Copy link
Contributor

Screenshot 2024-02-27 at 11 21 08

andreancardona
andreancardona approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good!

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Feb 27, 2024 •
edited
Loading

@jdharvey-ibm @francinelucca you ok with merging?

@jharvey10
Copy link
Contributor

@alisonjoseph Yeah! Go for it!

@alisonjoseph alisonjoseph merged commit 24e9185 into main Feb 28, 2024
6 of 7 checks passed
@alisonjoseph alisonjoseph deleted the compliance-add-commonjs branch February 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharvey10 jharvey10 jharvey10 approved these changes

@andreancardona andreancardona andreancardona approved these changes

@francinelucca francinelucca Awaiting requested review from francinelucca francinelucca is a code owner automatically assigned from carbon-design-system/carbon-platform-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alisonjoseph @carbon-bot @jharvey10 @andreancardona