Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProgressStep] aria-disabled not supported by implied role 'listitem' #1683

Closed
theetrain opened this issue Mar 11, 2023 · 4 comments · Fixed by #1703
Closed

[ProgressStep] aria-disabled not supported by implied role 'listitem' #1683

theetrain opened this issue Mar 11, 2023 · 4 comments · Fixed by #1703
Labels
bug Something isn't working

Comments

@theetrain
Copy link
Collaborator

Svelte 3.56.0 yields this warning:

A11y: The attribute 'aria-disabled' is not supported by the role 'listitem'. This role is implicit on the element <li>

And it calls out this line:

<li
aria-disabled="{disabled}"
id="{id}"
class:bx--progress-step="{true}"

We should address the warning; Carbon react does not use aria-disabled and instead makes use of tabindex="-1" on list buttons that are disabled.

@theetrain theetrain added the bug Something isn't working label Mar 11, 2023
@theetrain
Copy link
Collaborator Author

References:

Takeaways

  • Use aria-current="true"
  • Have visually-hidden text indicate completed, current, next, and disabled steps

Out of scope

@pwwang
Copy link

pwwang commented Mar 24, 2023

It's not only ProgressIndicator/ProgressStep that is affected. Here is a list of components that are affected:

  • ContextMenu
  • OverflowMenu
  • UIShell/HeaderNavMenu
  • UIShell/SideNavMenu
  • UIShell/HeaderSearch
  • UIShell/HeaderNav
  • Tabs
  • TreeView/TreeView
  • TreeView/TreeViewNodeList
  • TreeView/TreeViewNode

@metonym
Copy link
Collaborator

metonym commented Mar 25, 2023

@pwwang Thank you for flagging this. I submitted a PR here: #1703

@theetrain
Copy link
Collaborator Author

Resolved in v0.73.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants