From 07a39db8e0d447caff3ad551e685d9a1d1ef6681 Mon Sep 17 00:00:00 2001
From: Roman Wozniak <roman.wozniak@gojek.com>
Date: Mon, 30 Oct 2023 14:11:02 +0800
Subject: [PATCH] Add minReadySeconds & strategy support for
 caraml-store/serving chart

---
 charts/caraml-store/Chart.yaml                        | 2 +-
 charts/caraml-store/README.md                         | 2 ++
 charts/caraml-store/templates/serving/deployment.yaml | 7 +++++++
 charts/caraml-store/values.yaml                       | 6 ++++++
 4 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/charts/caraml-store/Chart.yaml b/charts/caraml-store/Chart.yaml
index 5298c1fb..7b84b785 100644
--- a/charts/caraml-store/Chart.yaml
+++ b/charts/caraml-store/Chart.yaml
@@ -20,4 +20,4 @@ maintainers:
 - email: caraml-dev@caraml.dev
   name: caraml-dev
 name: caraml-store
-version: 0.1.15
+version: 0.1.16
diff --git a/charts/caraml-store/README.md b/charts/caraml-store/README.md
index 8b528c37..7e54ca12 100644
--- a/charts/caraml-store/README.md
+++ b/charts/caraml-store/README.md
@@ -85,6 +85,7 @@ CaraML store registry: Feature registry for CaraML store.
 | serving.image.tag | string | `""` |  |
 | serving.imagePullSecrets | list | `[]` |  |
 | serving.javaOpts | string | `nil` |  |
+| serving.minReadySeconds | int | `0` | The minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. |
 | serving.name | string | `"serving"` |  |
 | serving.nameOverride | string | `""` |  |
 | serving.nodeSelector | object | `{}` |  |
@@ -104,6 +105,7 @@ CaraML store registry: Feature registry for CaraML store.
 | serving.service.grpc.port | int | `6566` | Service port for GRPC requests |
 | serving.service.grpc.targetPort | int | `6566` | Container port serving GRPC requests |
 | serving.service.type | string | `"ClusterIP"` | Kubernetes service type |
+| serving.strategy | object | `{}` | Strategy used to replace old Pods by new ones. .spec.strategy.type can be "Recreate" or "RollingUpdate". "RollingUpdate" is the default value. |
 | serving.tolerations | list | `[]` |  |
 
 ----------------------------------------------
diff --git a/charts/caraml-store/templates/serving/deployment.yaml b/charts/caraml-store/templates/serving/deployment.yaml
index ec7ec6a1..82a19c5e 100644
--- a/charts/caraml-store/templates/serving/deployment.yaml
+++ b/charts/caraml-store/templates/serving/deployment.yaml
@@ -8,6 +8,13 @@ metadata:
     {{- include "caraml-store.serving.labels" . | nindent 4 }}
 spec:
   replicas: {{ .Values.serving.replicaCount }}
+{{- if .Values.serving.strategy }}
+  strategy:
+{{ toYaml .Values.serving.strategy | indent 4 }}
+{{- end }}
+{{- if .Values.serving.minReadySeconds }}
+  minReadySeconds: {{ .Values.serving.minReadySeconds }}
+{{- end }}
   selector:
     matchLabels:
       {{- include "caraml-store.serving.selectorLabels" . | nindent 6 }}
diff --git a/charts/caraml-store/values.yaml b/charts/caraml-store/values.yaml
index 8dbff248..8fcc0e0a 100644
--- a/charts/caraml-store/values.yaml
+++ b/charts/caraml-store/values.yaml
@@ -124,6 +124,12 @@ serving:
 
   secrets: []
 
+  # serving.strategy -- Strategy used to replace old Pods by new ones. .spec.strategy.type can be "Recreate" or "RollingUpdate". "RollingUpdate" is the default value.
+  strategy: {}
+
+  # serving.minReadySeconds -- The minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available.
+  minReadySeconds: 0
+
   podLabels: {}
   podAnnotations: {}
   service: