Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in the design of built-in apps #19

Open
erikinkinen opened this issue Mar 5, 2022 · 2 comments
Open

Inconsistencies in the design of built-in apps #19

erikinkinen opened this issue Mar 5, 2022 · 2 comments

Comments

@erikinkinen
Copy link
Contributor

Almost every app has a different-coloured background which fails to give the impression of consistent design.

Environment

  • Desktop Linux
  • Desktop Mac
  • Device

To Reproduce
Steps to reproduce the behavior:

  1. Open a lot of built-in apps.
  2. Look at them
  3. Notice the inconsistencies I described.

Expected behavior
Every app should have a similar design with for example a white background.

Additional context
The backgrounds are probably the most prominent inconsistency but there might be other ones as well hidden behind the prominence of the backgrounds.

@fabricedesre
Copy link
Contributor

Right... I've been looking at re-using an existing set of UI components to have a better consistency (and quality!). I think Shoelace could be a good option since shoelace-style/shoelace#571 is closed.

I have a WIP branch for the First Time Use app where I'm testing it. Hopefully will be ready in the coming weeks, and based on how this goes we could migrate other apps too.

@erikinkinen
Copy link
Contributor Author

@fabricedesre
I started migrating settings to shoelace.
#22 is a draft PR where you can take a look at the work I've done already. I also attach the mock-ups I sent in the chat here.

settings-mainmenu

settings-wifi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants