imbue builders and readers with cap tables #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaci
force-pushed
the
vaci/cap-table
branch
6 times, most recently
from
fed5efc
to
40f1b2a
Compare
|
Is there a reason this was never reviewed? Is the intention to never add RPC support to the Java implementation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement the RPC features of Capnproto in Java, the most intrusive change to the existing codebase is to imbue builders and readers with the tables for tracking references to any capabilities that may be associated with an arena.
This patch does the trivial but tedious work of wiring capability tables into builders and readers. Backward compatibility is maintained in existing method signatures by defaulting the optional capTable parameter to null.