isSupported, isTorchAvailable, isGoogleBarcodeScannerModuleAvailable should just return false by default on web, instead of throwing an exception

[htran-ubed]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @capacitor-mlkit/[email protected] for the project I'm working on.

Functions isSupported, isTorchAvailable, isGoogleBarcodeScannerModuleAvailable that check if functionality is available should just return false if it is not supported or not available, instead of throwing a Capacitor exception.

Here is the diff that solved my problem:

diff --git a/node_modules/@capacitor-mlkit/barcode-scanning/dist/esm/web.js b/node_modules/@capacitor-mlkit/barcode-scanning/dist/esm/web.js
index 081161f..9f2d2f5 100644
--- a/node_modules/@capacitor-mlkit/barcode-scanning/dist/esm/web.js
+++ b/node_modules/@capacitor-mlkit/barcode-scanning/dist/esm/web.js
@@ -13,7 +13,7 @@ export class BarcodeScannerWeb extends WebPlugin {
         throw this.createUnavailableException();
     }
     async isSupported() {
-        throw this.createUnavailableException();
+        return false;
     }
     async enableTorch() {
         throw this.createUnavailableException();
@@ -28,7 +28,7 @@ export class BarcodeScannerWeb extends WebPlugin {
         throw this.createUnavailableException();
     }
     async isTorchAvailable() {
-        throw this.createUnavailableException();
+        return false;        
     }
     async setZoomRatio(_options) {
         throw this.createUnavailableException();
@@ -46,7 +46,7 @@ export class BarcodeScannerWeb extends WebPlugin {
         throw this.createUnavailableException();
     }
     async isGoogleBarcodeScannerModuleAvailable() {
-        throw this.createUnavailableException();
+        return false;
     }
     async installGoogleBarcodeScannerModule() {
         throw this.createUnavailableException();

This issue body was partially generated by patch-package.

[robingenz]

Thank you for creating this request. It's common to throw an exception if a method is not available on a specific platform. You can just wrap that call in a try-catch. No need to patch/fork the plugin. I'm therefore closing this issue as not planned.

[htran-ubed]

isSupported should be available on all platforms. It makes no sense to have to wrap such in try catch.

[robingenz]

Feel free to create a PR for that method.