Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(barcode-scanning): add web support #211

Closed
wants to merge 8 commits into from

Conversation

iBobik
Copy link

@iBobik iBobik commented Nov 24, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Try it

For my and you convenience here is build: capacitor-mlkit-barcode-scanning-6.2.0.tgz
You can install it in your project like this:

npm i @capacitor-mlkit/barcode-scanning@https://github.com/user-attachments/files/17894704/capacitor-mlkit-barcode-scanning-6.2.0.tgz

@iBobik iBobik changed the base branch from feat/issue-20 to main November 24, 2024 19:30
@robingenz
Copy link
Member

Hi @iBobik, we are currently not planning to add web support to these plugins. :/ This is because these are plugins for the ML Kit SDK and we will only add web support when the ML Kit SDK officially supports the web. Feel free to upvote this suggestion. However, we are already working on another solution. More updates coming soon! Thanks for your contribution though! I will close this PR for now.

@robingenz robingenz closed this Nov 24, 2024
@iBobik
Copy link
Author

iBobik commented Nov 24, 2024

Hmm, better to hear it on that another unmaintained PR (which is there for months) before I spend a days on it debugging it with the current version.

However I need it working now, it works in my project, so I will maintain this branch until I find something else what will implement all 3 platforms in one plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants