Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(barcode-scanning): support all barcode types #206

Merged
merged 9 commits into from
Nov 13, 2024
Merged

feat(barcode-scanning): support all barcode types #206

merged 9 commits into from
Nov 13, 2024

Conversation

mertyldrr
Copy link

@mertyldrr mertyldrr commented Nov 9, 2024 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been (partially)tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #105

@robingenz robingenz changed the title feat(barcode-scanning): extend definitions with new properties feat(barcode-scanning): support all barcode types Nov 9, 2024
robingenz
robingenz requested changes Nov 9, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have a few comments.

Btw: Thanks for sorting alphabetically. ^^

packages/barcode-scanning/src/definitions.ts Outdated Show resolved Hide resolved
packages/barcode-scanning/src/definitions.ts Outdated Show resolved Hide resolved
packages/barcode-scanning/src/definitions.ts Outdated Show resolved Hide resolved
packages/barcode-scanning/src/definitions.ts Outdated Show resolved Hide resolved
packages/barcode-scanning/src/definitions.ts Outdated Show resolved Hide resolved
.changeset/mighty-comics-whisper.md Outdated Show resolved Hide resolved
@mertyldrr mertyldrr requested a review from robingenz November 9, 2024 20:16
@robingenz
Copy link
Member

Android looks good so far. Feel free to continue with iOS.

@mertyldrr mertyldrr marked this pull request as ready for review November 12, 2024 20:02
@mertyldrr mertyldrr requested a review from robingenz November 12, 2024 20:02
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 12, 2024 •
edited
Loading

Open in Stackblitz

@capacitor-mlkit/barcode-scanning

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/barcode-scanning@206

@capacitor-mlkit/face-detection

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/face-detection@206

@capacitor-mlkit/face-mesh-detection

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/face-mesh-detection@206

@capacitor-mlkit/selfie-segmentation

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/selfie-segmentation@206

@capacitor-mlkit/translation

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/translation@206

commit: 5ae91cd

@mertyldrr mertyldrr requested a review from robingenz November 12, 2024 21:07
robingenz
robingenz approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #206 (comment)

@robingenz
Copy link
Member

@mertyldrr Thank you for your first contribution! 💜

@robingenz robingenz merged commit c0c29b9 into capawesome-team:next Nov 13, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@robingenz robingenz mentioned this pull request Dec 5, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees

@mertyldrr mertyldrr

Labels
feature Feature package: barcode-scanning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertyldrr @robingenz