Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(barcode-scanning): support cornerPoints in readBarcodesFromImage(...) #39

Open
4 of 7 tasks
tigohenryschultz opened this issue May 23, 2023 · 4 comments · May be fixed by #100
Open
4 of 7 tasks

feat(barcode-scanning): support cornerPoints in readBarcodesFromImage(...) #39

tigohenryschultz opened this issue May 23, 2023 · 4 comments · May be fixed by #100
Assignees
@ebarooni
Labels
feature Feature good first issue Good for newcomers package: barcode-scanning
Milestone
v7.0.0

Comments

@tigohenryschultz
Copy link

Plugin(s)

  • Barcode Scanning
  • Translation

Did you test the latest version?

  • I use the latest version

Platform(s)

  • Android
  • iOS
  • Web

Current behavior

cornerPoints is empty

Expected behavior

cornerPoints should have points

Reproduction

https://github.com/tigohenryschultz/ionic-cap-ml-barcode-test

Steps to reproduce

  1. Go to the ML Kit tab
  2. Click take a picture
  3. Missing points data

Code is in TgMLKitBarcodes.vue

Other information

3
: 
bytes
: 
(9) [52, 45, 50, 68, 48, 55, 69, 50, 84]
cornerPoints
: 
[]
displayValue
: 
"4-2D07E2T"
format
: 
"QR_CODE"
rawValue
: 
"4-2D07E2T"
valueType
: 
"TEXT"
[[Prototype]]
: 
Object
4
: 
{bytes: Array(9), cornerPoints: Array(0), displayValue: '4-2D0775R', format: 'QR_CODE', rawValue: '4-2D0775R', …}
5
: 
{bytes: Array(9), cornerPoints: Array(0), displayValue: '4-2D0765X', format: 'QR_CODE', rawValue: '4-2D0765X', …}
6
: 
bytes
: 
(9) [52, 45, 50, 67, 57, 68, 56, 53, 77]
cornerPoints
: 
Array(0)
length
: 
0
[[Prototype]]
: 
Array(0)
displayValue
: 
"4-2C9D85M"
format
: 
"QR_CODE"
rawValue
: 
"4-2C9D85M"
valueType
: 
"TEXT"
[[Prototype]]
: 
Object
7
: 
{bytes: Array(9), cornerPoints: Array(0), displayValue: '4-2D07EFY', format: 'QR_CODE', rawValue: '4-2D07EFY', …}
8
: 
bytes
: 
(9) [52, 45, 50, 67, 57, 67, 68, 56, 87]
cornerPoints
: 
[]
displayValue
: 
"4-2C9CD8W"
format
: 
"QR_CODE"
rawValue
: 
"4-2C9CD8W"
valueType
: 
"TEXT"
[[Prototype]]
: 
Object

image

Capacitor doctor

Latest Dependencies:

@capacitor/cli: 5.0.4
@capacitor/core: 5.0.4
@capacitor/android: 5.0.4
@capacitor/ios: 5.0.4

Installed Dependencies:

@capacitor/cli: 5.0.3
@capacitor/core: 5.0.3
@capacitor/android: 5.0.3
@capacitor/ios: 5.0.3

Before submitting

  • I understand that incomplete issues (e.g. without reproduction) are closed.
@tigohenryschultz tigohenryschultz added bug/fix Something isn't working needs: triage labels May 23, 2023
@tigohenryschultz
Copy link
Author

Adding this debug code I see getBoundingBox has some information:

image

@robingenz
Copy link
Member

Thank you for reporting this. I will take a closer look the next days.

@robingenz robingenz changed the title bug: Barcodes do not contain corner points bug(barcode-scanning): Barcodes do not contain corner points May 26, 2023
@robingenz robingenz added good first issue Good for newcomers feature Feature package: barcode-scanning and removed needs: triage bug/fix Something isn't working labels May 31, 2023
@robingenz
Copy link
Member

The readBarcodesFromImage(...) method does not yet support the calculation of cornerPoints. I have now documented this (see here) and converted the issue into a feature request.
PRs are welcome.

@robingenz robingenz changed the title bug(barcode-scanning): Barcodes do not contain corner points feat(barcode-scanning): support cornerPoints in readBarcodesFromImage(...) Jun 2, 2023
@nurfgun nurfgun linked a pull request Nov 23, 2023 that will close this issue
Open
2 tasks
@robingenz robingenz added this to the v5.4.0 milestone Dec 8, 2023
@robingenz robingenz modified the milestones: v5.4.0, v6.0.0 Feb 5, 2024
@robingenz robingenz modified the milestones: v6.0.0, v7.0.0 Apr 16, 2024
@robingenz
Copy link
Member

@ebarooni Feel free to work on this issue. There is already a PR which you can use as inspiration: #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebarooni ebarooni

Labels
feature Feature good first issue Good for newcomers package: barcode-scanning
Projects
None yet
Milestone
v7.0.0
3 participants
@robingenz @ebarooni @tigohenryschultz