Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test on fresh clone failes due to undeclared dependencies #351

Open
mdavis-xyz opened this issue Apr 15, 2018 · 1 comment
Open

make test on fresh clone failes due to undeclared dependencies #351

mdavis-xyz opened this issue Apr 15, 2018 · 1 comment

Comments

@mdavis-xyz
Copy link

mdavis-xyz commented Apr 15, 2018

Steps to reproduce

git clone https://github.com/caolan/nodeunit.git
cd nodeunit
make test

Expected behaviour

All tests pass

Actual behaviour

nodejs ./bin/nodeunit test             
module.js:471                          
    throw err;                         
    ^                                  
                                       
Error: Cannot find module 'ejs'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)                                
    at Module.require (module.js:497:17)                                       
    at require (internal/module.js:20:19)                                      
    at Object.<anonymous> (/home/matthew/Documents/Projects/nodeunit/nodeunit/lib/reporters/junit.js:18:11)
    at Module._compile (module.js:570:32)                                                                                                                      
    at Object.Module._extensions..js (module.js:579:10)                        
    at Module.load (module.js:487:32)                                          
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
Makefile:148: recipe for target 'test' failed                                  
make: *** [test] Error 1                      

Commentary

The make script should run npm install ejs and npm install should, since those are dependencies.

I'm new to nodejs and Make files, so I'm not quite sure how to do this.

@brodycj
Copy link
Contributor

brodycj commented Jul 9, 2018

Isn't the normal procedure to do npm i (short for npm install) before npm test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants