Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-16836 Rebranded /landscape/features page #14576

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Dec 16, 2024

Done

  • Rebranded page
  • Updated assets

QA

Issue / Card

Fixes #WD-16836

@webteam-app
Copy link

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-rebrand-landscape@0499cb8). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-rebrand-landscape   #14576   +/-   ##
============================================================
  Coverage                             ?   69.64%           
============================================================
  Files                                ?      120           
  Lines                                ?     3419           
  Branches                             ?     1178           
============================================================
  Hits                                 ?     2381           
  Misses                               ?     1013           
  Partials                             ?       25           

@eliman11
Copy link

eliman11 commented Dec 16, 2024

Thanks @muhammad-ali-pk! Comments:

  • In the hero paragraph, add 'and embedded devices' and remove 'and' before 'clouds' as marked by the PM on the copydoc --> should be 'Landscape is the most cost-effective way to support and administer large and growing networks of desktops, servers, clouds, and embedded devices.'
  • Add ', and scale up for larger deployments' under 'Systems management', marked on copydoc
  • 'Scriptable API to customise Landscape for your organisation’s needs' change to US spelling (customize, organization's)
  • Redirect 'Get Landscape' CTA at the bottom to /landscape/compare (formerly /pricing) instead

@mattea-turic
Copy link
Collaborator

mattea-turic commented Dec 16, 2024

Thanks @muhammad-ali-pk , this is pretty much perfect :p

Just one question:

  • Could you have the images fill the containers and adjust to screen size accordingly? Obv you know a lot more than I do about what's possible, but could we do something like this i.e. object-fit: cover; in css

This is how it is atm on med screens:
Screenshot 2024-12-16 at 13 47 51

And on mobile:
Screenshot 2024-12-16 at 13 48 18

@muhammad-ali-pk
Copy link
Contributor Author

@eliman11 Thanks! Done!

@muhammad-ali-pk
Copy link
Contributor Author

@mattea-turic Thanks Mattea! It's done. Also, for the first and the last image, I have added object-position: top so that the person's face isn't cut off and look weird on medium/smaller screen. The other two's have default and look fine.

@eliman11
Copy link

Looks great @muhammad-ali-pk thank you!

@mattea-turic
Copy link
Collaborator

Thank you @muhammad-ali-pk , looks really nice!

templates/landscape/features.html Outdated Show resolved Hide resolved
templates/landscape/features.html Outdated Show resolved Hide resolved
templates/landscape/features.html Outdated Show resolved Hide resolved
templates/landscape/features.html Show resolved Hide resolved
templates/landscape/features.html Show resolved Hide resolved
templates/landscape/features.html Outdated Show resolved Hide resolved
@muhammad-ali-pk muhammad-ali-pk force-pushed the landscape-features-rebrand branch from 82f58d9 to 74e7e1e Compare December 20, 2024 12:09
@muhammad-ali-pk muhammad-ali-pk merged commit 4b010b6 into canonical:feature-rebrand-landscape Dec 20, 2024
15 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the landscape-features-rebrand branch December 20, 2024 12:42
muhammad-ali-pk added a commit that referenced this pull request Dec 20, 2024
* rebrand /landscape

* updated quote image

* review design changes

* review changes

* WD-16842 Redirect /landscape/install to Docs (#14582)

* Remove /landscape/install and redirect to docs

* Point install to docs in  navigation

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16840 Rebranded /landscape/pricing page (#14581)

* Rebrand /landscape/pricing

1. Rename pricing to compare
2. Add redirect from pricing to compare

* Updated asset

* Applied UX review suggestions

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16838 Rebranded /landscape/managed page (#14580)

* Rebranded  /landscape/managed page

* Applied design review suggestions

* Triggering deployment

* Applied UX review suggestions

* Added a link

* Applied code review suggestions

* Enclose image module in a wrapper

* Removed unnecessary spacing

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16836 Rebranded /landscape/features page (#14576)

* Rebranded /landscape/features page

* Applied UX review suggestions

* Applied design review changes

* lazy load images not in viewport

* Code review changes

* Added different assets for different screen sizes

---------

Co-authored-by: Muhammad Ali <[email protected]>

---------

Co-authored-by: immortalcodes <[email protected]>
Co-authored-by: Madhur Jain <[email protected]>
Co-authored-by: Muhammad Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants