WD-17753 Iot embedded modal form - removed pagination + conversion to single page #14567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
muhammad-ali-pk
added
Review: QA +1
Review: Code +1
Review: QA needed
Review: Code needed
and removed
Review: QA +1
Review: Code +1
labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-iot #14567 +/- ##
====================================================
Coverage 69.64% 69.64%
====================================================
Files 120 120
Lines 3419 3419
Branches 1178 1174 -4
====================================================
Hits 2381 2381
Misses 1013 1013
Partials 25 25 |
muhammad-ali-pk
force-pushed
the
WD-16362
branch
from
3a29478 to
cc38310
Compare
fasih-mehmood
approved these changes
Dec 13, 2024
fasih-mehmood
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
muhammad-ali-pk
merged commit 5de51b9
into
canonical:feature-rebrand-iot
15 checks passed
muhammad-ali-pk
added a commit
that referenced
this pull request
Dec 13, 2024
* Apply page redesign * Apply design suggestions * Apply design fixes * Bump vanilla version and switch to quote macros * Apply code review * Apply page redesign * Apply design review * Update asset * Fix blog IoT blog variables * Rebrand /iot/smart-displays * rebrand /internet-of-things/gateways * review changes * Apply code review * review changes * WD-16635 Redesigned internet-of-things/management (#14529) * Redesigned internet-of-things/management * Applied design review * Fix missing hr's on smaller screens (using vanilla patterns) * Applied UX Review * Use image module * Fix line breaks + use hr for p-rule * Removed unnecessary outer_content block * Fixed line break --------- Co-authored-by: Muhammad Ali <[email protected]> * WD-17582 Redirect to success notification instead of thank-you page. (#14545) * Fix: not redirected to static contact-us page when javascript is disabled * Redirect to success banner upon form submission --------- Co-authored-by: Muhammad Ali <[email protected]> * Adress visual design comments * Address UX comments * Use modal form on iot/management (#14548) Co-authored-by: Muhammad Ali <[email protected]> * WD-16645 Redesigned internet-of-things/smart-city (#14534) * Redesigned internet-of-things/smart-city * Accessible headings order * Reduced padding for image with h5 * Applied UX Review * Structural hierarchy cleanup * Use image module * Applied design review * Applied code review --------- Co-authored-by: Muhammad Ali <[email protected]> * review design changes * Address design comments * WD-16647 Redesigned internet-of-things/smart-home (#14530) * Redesigned iot/smart-home * Applied design review * Applied UX Review * Applied code review * Applied code review suggestions --------- Co-authored-by: Muhammad Ali <[email protected]> * Update logos * copydoc update * Apply code review suggestions * WD-16633 Rebranded embedded (#14544) * Rebranded embedded page * Quick fix: remove empty tag * Applied UX Review * Applied design review suggestions * Added aria-labels on Learn more.* links * Lazy load images not currently in viewport * Added a shallow section around image (design suggestion) --------- Co-authored-by: Muhammad Ali <[email protected]> * WD-17646 Removed pagination from modal form and converted to single page (#14555) * Removed pagination from modal form and converted to single page * Applied design review suggestion --------- Co-authored-by: Muhammad Ali <[email protected]> * fix: appstore contact-form not opening in popup * WD-17753 Iot embedded modal form - removed pagination + conversion to single page (#14567) * Removed pagination + conversion to single page * Cleanup --------- Co-authored-by: Muhammad Ali <[email protected]> * Updated new thank-you banner * format gateways.html * Removed pagination + refactor (#14570) Co-authored-by: Muhammad Ali <[email protected]> * Removed pagination + refactor (#14571) Co-authored-by: Muhammad Ali <[email protected]> --------- Co-authored-by: Britney Wang <[email protected]> Co-authored-by: immortalcodes <[email protected]> Co-authored-by: Muhammad Ali <[email protected]> Co-authored-by: Muhammad Ali <[email protected]> Co-authored-by: Akbar Abdrakhmanov <[email protected]> Co-authored-by: Britney Wang <[email protected]> Co-authored-by: Madhur Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Issue / Card
Fixes #WD-17753