Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move about link and fix broken link #984

Merged
merged 3 commits into from
Nov 27, 2024
Merged

fix: Move about link and fix broken link #984

merged 3 commits into from
Nov 27, 2024

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Nov 27, 2024

Moves the About Ubuntu Pro button functionality to a Learn More link in the above copy. Also fixes the issue of the link not opening.

Screenshot of change


UDENG-5282

@ashuntu ashuntu self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (c7baeea) to head (d6a4d25).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
+ Coverage   89.14%   89.16%   +0.02%     
==========================================
  Files         110      110              
  Lines        7515     7515              
==========================================
+ Hits         6699     6701       +2     
+ Misses        637      635       -2     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu ashuntu marked this pull request as ready for review November 27, 2024 18:42
@ashuntu ashuntu requested a review from a team as a code owner November 27, 2024 18:42
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach. Just one minor concern about l10n.

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@ashuntu ashuntu merged commit 27e45e6 into main Nov 27, 2024
30 checks passed
@ashuntu ashuntu deleted the fix-about-link branch November 27, 2024 21:11
ashuntu added a commit that referenced this pull request Dec 2, 2024
Updates all screenshots that feature the Flutter app to the current
design.

*This is based on the open PR
#984 for the most
recent design.*

---

UDENG-5426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants