feat(windows-agent): Redirect agent logs to LocalAppData #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
agent-logs
branch
4 times, most recently
from
a661b9c to
3fca65e
Compare
Printing them when tests succeed causes too much spam when running with the verbose flag (yes, it's too verbose for verbose mode).
It fixes a couple issues in the logs and makes it more similar to the new logWindowsAgentJournal.
EduardGomezEscandell
force-pushed
the
agent-logs
branch
from
1b9e20e to
e7c1c31
Compare
|
Rebased main, no new changes. |
EduardGomezEscandell
requested review from
didrocks and
CarlosNihelton
and removed request for
didrocks
and rename it to a more accurate logWslProServiceOnError.
and rename it to a more accurate logWindowsAgentOnError.
EduardGomezEscandell
requested review from
CarlosNihelton
and removed request for
CarlosNihelton
CarlosNihelton
approved these changes
Nov 22, 2023
didrocks
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very useful for end-to-end testing.
UDENG-1732