Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows-agent): Use registry multiline string for Landscape Config #350

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

EduardGomezEscandell
Copy link
Contributor

@EduardGomezEscandell EduardGomezEscandell commented Oct 20, 2023

This is a QOL improvement for the user.

In the registry, the Landscape configuration is now by default of type REG_MULTI_SZ. Other keys still default to REG_SZ.

This essentially means that the user will not need to delete LandscapeClientConfig to re-create it with the expanded type.

I tested it manually to verify it worked.


UDENG-1603

@EduardGomezEscandell EduardGomezEscandell changed the title Use registry multiline string for Landscape Config fix(windows-agent): Use registry multiline string for Landscape Config Oct 20, 2023
@EduardGomezEscandell EduardGomezEscandell force-pushed the use-registry-multiline-string branch from d7033de to 2ebb11c Compare October 20, 2023 12:57
@EduardGomezEscandell EduardGomezEscandell self-assigned this Oct 23, 2023
@EduardGomezEscandell
Copy link
Contributor Author

EduardGomezEscandell commented Oct 23, 2023

CI failure is due to rate limiting:

Run arduino/setup-protoc@v2
Error: Error: API rate limit exceeded for 104.45.202.155. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

I'm already working on fixing this, but I think we can go ahead with the review anyway.

@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review October 23, 2023 07:24
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@EduardGomezEscandell EduardGomezEscandell merged commit 44ad779 into main Oct 24, 2023
34 checks passed
@EduardGomezEscandell EduardGomezEscandell deleted the use-registry-multiline-string branch October 24, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants