fix(storeapi): Allows fallback to the old API for JWT generation #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosNihelton
force-pushed
the
fix-jwt-gen
branch
from
4f3be28 to
227b6f0
Compare
|
I guess we are stuck with the build debian action failing for now. |
EduardGomezEscandell
previously approved these changes
Oct 17, 2023
CarlosNihelton
force-pushed
the
fix-jwt-gen
branch
from
4ce2d84 to
e1511e6
Compare
EduardGomezEscandell
dismissed
their stale review
The base branch was changed.
EduardGomezEscandell
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Windows.Services.StorenamespaceStoreContextclass is consistently failing to generate the user JWT without an error message, just returning an empty string, which is not helpful.To date I'm not sure what's going on under the hood, but the fact is that, once deployed, using the old (deprecated)
Windows.ApplicationModel.StorenamespaceCurrentAppclass always succeeds (or generates a useful error message if the access token has issues - such as being expired).So, this PR adds allows the old namespace call as a fallback for such cases.
With such fix in place I'm seeing the agent logs consistently hitting the wall of the WSL SaaS backend failing to respond to the
GET /v1/subscriptioncall, which is only made after we suceed in generating the JWT (which follows sucessfully checking the current expiration date with the Store API).