feat(landscape): Implement support for SSL certificates in Landscape connection #320
+426
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
landscape-ssl
branch
7 times, most recently
from
d360c61 to
333f76c
Compare
didrocks
requested changes
Oct 12, 2023
didrocks
approved these changes
Oct 16, 2023
We need to modify the config on WSL's side because it'll need access to wslpath once we implement support for the ssl certificate.
The mocked "cmd.exe echo %LocalAppData%" would return a Linux path, and then the mocked "wslpath" would do nothing. Of course, this is not accurate, as cmd.exe returns always the Windows path. This is here fixed.
EduardGomezEscandell
force-pushed
the
landscape-ssl
branch
from
f7cc18a to
9b04178
Compare
|
Force-pushed to rebase main and squashed fixups, no changes to code. |
EduardGomezEscandell
requested review from
didrocks
and removed request for
didrocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes in this PR:
computer_nameoverride took place in the agent, when creating the task. This is now moved to the WSL Pro Service.computer_name, the WSL Pro Service will now also rewritessl_public_keyso that it is converted from Windows path to WSL path. This step is skipped if this key is not present.ssl_public_keywhen available. This key will be used to secure the connection to the Hostagent server.UDENG-1544