fix(gui): SubscribeNowPage calls back also when applying manually supplied token.
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosNihelton
force-pushed
the
update-subs-on-manual
branch
from
497725f to
da278df
Compare
for the callback the subscribe now page calls when susbcription changes. Also, make sure to call it for the manual input token case. It was previously only used for the purchase through store case.
CarlosNihelton
force-pushed
the
update-subs-on-manual
branch
from
da278df to
23ffe22
Compare
CarlosNihelton
changed the title
onSubscriptionUpdate is a better name for this callbackonSubscriptionUpdate is a better name for this callback
|
Not sure the title of the PR reflects this PR, as this is not just a rename. |
CarlosNihelton
changed the title
onSubscriptionUpdate is a better name for this callbackSubscribeNowPage calls back also when applying manually supplied token.
|
Hard to find a short name :) |
EduardGomezEscandell
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SubscribeNowPageaccepts a callback that must be called when this page causes the current subscription to change, such as when the user purchases a subscription through the store. It turns out that the callback was being called only in such situation, thus the previous name made sense.But that was a mistake: user manual input also causes the underlying subscription to change, thus that must also call the callback. Hence, the reason for renaming it.
This not only renames it, but also ensures it is called for the manual input case.