Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reorganize subscription status #1017

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Dec 17, 2024

Reorganizes the subscription status page (the last past) according to new designs. Notably, this changes some copy, moves management links to footer text links, and uses generally the same look no matter what type of management.

image

Note that this page will change significantly in the future to support Landscape configuration statuses. This is just a UI update only.


UDENG-5591

@ashuntu ashuntu self-assigned this Dec 17, 2024
@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 17, 2024

This removes some of the copy about being an org managed/store managed/manually managed page. I'm not sure if we still want those elements, but I think maybe we could replace the manage subscription link at the bottom with "This subscription is managed by your organization" when org managed. Or, keep it as is. I don't believe we have new designs for this.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (7de7271) to head (2af76cb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   89.12%   89.14%   +0.02%     
==========================================
  Files         112      112              
  Lines        7511     7498      -13     
==========================================
- Hits         6694     6684      -10     
+ Misses        641      638       -3     
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 17, 2024

LandscapePage can likely be removed after #1015 is merged.

@ashuntu ashuntu marked this pull request as ready for review December 17, 2024 23:23
@ashuntu ashuntu requested a review from a team as a code owner December 17, 2024 23:23
@CarlosNihelton
Copy link
Contributor

I think maybe we could replace the manage subscription link at the bottom with "This subscription is managed by your organization" when org managed.

I like this suggestion better. I'm missing some feedback about this. We might ask Juan about it during our next UX review, if you prefer. I honestly consider that a useful piece of information.

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean start. I like the way you've been introducing those changes piecewise. I have few things to address.

@ashuntu ashuntu force-pushed the reorganize-subscription-status branch from 01ffbda to 63fbed2 Compare December 18, 2024 15:11
@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 18, 2024

Rebased on main

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 18, 2024

@CarlosNihelton 1 more commit to remove the LandingPage widget since its unused. Shouldn't change anything, and I'll merge once tests pass if nothing comes up :)

@ashuntu ashuntu merged commit aea00b5 into main Dec 18, 2024
36 checks passed
@ashuntu ashuntu deleted the reorganize-subscription-status branch December 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants