-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reorganize subscription status #1017
Conversation
This removes some of the copy about being an org managed/store managed/manually managed page. I'm not sure if we still want those elements, but I think maybe we could replace the manage subscription link at the bottom with "This subscription is managed by your organization" when org managed. Or, keep it as is. I don't believe we have new designs for this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 89.12% 89.14% +0.02%
==========================================
Files 112 112
Lines 7511 7498 -13
==========================================
- Hits 6694 6684 -10
+ Misses 641 638 -3
Partials 176 176 ☔ View full report in Codecov by Sentry. |
|
I like this suggestion better. I'm missing some feedback about this. We might ask Juan about it during our next UX review, if you prefer. I honestly consider that a useful piece of information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean start. I like the way you've been introducing those changes piecewise. I have few things to address.
gui/packages/ubuntupro/test/pages/subscription_status/subscription_status_page_test.dart
Show resolved
Hide resolved
Adjusts copy, adds text links to the bottom of the page, and aligns the design across all types of subscription management
01ffbda
to
63fbed2
Compare
Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
@CarlosNihelton 1 more commit to remove the LandingPage widget since its unused. Shouldn't change anything, and I'll merge once tests pass if nothing comes up :) |
Reorganizes the subscription status page (the last past) according to new designs. Notably, this changes some copy, moves management links to footer text links, and uses generally the same look no matter what type of management.
Note that this page will change significantly in the future to support Landscape configuration statuses. This is just a UI update only.
UDENG-5591