[DPE-3684] Prevent stuck raft cluster on leader departure #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 70.89% 69.18% -1.71%
==========================================
Files 12 12
Lines 3030 3109 +79
Branches 536 556 +20
==========================================
+ Hits 2148 2151 +3
- Misses 768 844 +76
Partials 114 114 ☔ View full report in Codecov by Sentry. |
dragomirp
force-pushed
the
dpe-3684-raft
branch
from
96b3991 to
1b187f5
Compare
| """Try to remove a raft member calling a partner node.""" | ||
| for attempt in Retrying(stop=stop_after_delay(60), wait=wait_fixed(3), reraise=True): | ||
| with attempt: | ||
| if not self._patroni.stop_patroni(): |
There was a problem hiding this comment.
Does this change the leader in the raft cluster? (if the unit where Patroni is being stopped was the raft cluster leader)
Comment on lines
+1076
to
+1081
| if not status: | ||
| raft_host = "localhost:2222" | ||
| if not (status := self._get_raft_status(syncobj_util, raft_host)): | ||
| logger.warning("Stopping unit: all raft members are unreachable") | ||
| self._patroni.stop_patroni() | ||
| return |
There was a problem hiding this comment.
I'm wondering if, in this situation, this unit can still be present in the raft cluster on the other units.
There was a problem hiding this comment.
I think it can be because of the network cut case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.