Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter controller use-istio config not used #322

Closed
misohu opened this issue Nov 27, 2023 · 0 comments · Fixed by #323
Closed

Jupyter controller use-istio config not used #322

misohu opened this issue Nov 27, 2023 · 0 comments · Fixed by #323
Labels
bug Something isn't working

Comments

@misohu
Copy link
Member

misohu commented Nov 27, 2023

Bug Description

In our jupyter controller we have config option use-istio. This option is never used. We just specify the USE_ISTIO environment option in the controller pebble service. We should set this envirnment value based on config value.

To Reproduce

None

Environment

None

Relevant Log Output

None

Additional Context

No response
@misohu misohu added the bug Something isn't working label Nov 27, 2023
@misohu misohu mentioned this issue Nov 29, 2023
Merged
@NohaIhab NohaIhab linked a pull request Nov 30, 2023 that will close this issue
Use use-istio config in charm.py #323
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use use-istio config in charm.py canonical/notebook-operators
2 participants
@misohu @NohaIhab