Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceAccount names are hardcoded in service environment variables #156

Open
NohaIhab opened this issue Oct 24, 2023 · 1 comment
Open

ServiceAccount names are hardcoded in service environment variables #156

NohaIhab opened this issue Oct 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@NohaIhab
Copy link
Contributor

NohaIhab commented Oct 24, 2023 •
edited
Loading

Bug Description

introduced in #155

The following environment variables are hardcoded, these env vars contain the names of ServiceAccounts owned by kubeflow charms, they should rather be passed with relation data:

  • ISTIO_INGRESS_GATEWAY_PRINCIPAL - SA is owned by istio-gateway charm, name is set here
  • NOTEBOOK_CONTROLLER_PRINCIPAL - SA is owned by jupyter-controller charm, it's ceated by juju to have the same name as the application.
  • KFP_UI_PRINCIPAL- SA is owned by kfp-ui charm, it's ceated by juju to have the same name as the application.

this can be implemented in a similar manner to istio_gateway_info library
@NohaIhab NohaIhab added the bug Something isn't working label Oct 24, 2023
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5497.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
MLOps Solution Issues
Status: Labeled
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NohaIhab