-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing user namespace label user.kubeflow.org/enabled
#127
Comments
phoevos
added a commit
that referenced
this issue
Jul 12, 2023
Add user.kubeflow.org/enabled: "true" to the list of labels pushed to the controller container to configure the labels added to newly created namespaces. Closes #127 Signed-off-by: Phoevos Kalemkeris <[email protected]>
For context, the |
phoevos
added a commit
that referenced
this issue
Jul 26, 2023
Add user.kubeflow.org/enabled: "true" to the list of labels pushed to the controller container to configure the labels added to newly created namespaces. Closes #127 Signed-off-by: Phoevos Kalemkeris <[email protected]>
phoevos
added a commit
that referenced
this issue
Jul 26, 2023
* Add user.kubeflow.org/enabled: "true" to the list of labels pushed to the controller container to configure the labels added to newly created namespaces * Add workflow action to save debug artifacts at the end of integrate.yaml Closes #127 Signed-off-by: Phoevos Kalemkeris <[email protected]>
re-opening this because it was not fixed in |
NohaIhab
pushed a commit
that referenced
this issue
Sep 29, 2023
* Add user.kubeflow.org/enabled: "true" to the list of labels pushed to the controller container to configure the labels added to newly created namespaces * Add workflow action to save debug artifacts at the end of integrate.yaml Closes #127 Signed-off-by: Phoevos Kalemkeris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Namespaces corresponding to Kubeflow users don't get the
user.kubeflow.org/enabled
label required by default by the Resource Dispatcher to detect the namespaces to inject resources into.More specifically, the Resource Dispatcher watches for newly created namespaces. If these carry a specific label (configured by the user), it injects the resources required for its related apps to work into the new namespaces. If the Resource Dispatcher is related with MLFlow, for instance, it will have to create PodDefaults and Secrets in the target namespaces to allow workloads running in them to access external services (e.g. MinIO). This label is essentially used to distinguish namespaces belonging to Kubeflow users and is set by default to
user.kubeflow.org/enabled: "true"
.The Profiles Operator, on the other hand, is the one that controls the labels that will end up on a new namespace, whenever a Kubeflow user Profile is created, through a YAML file pushed to the controller container. The labels currently propagated to the namespace are configured here:
kubeflow-profiles-operator/src/templates/namespace-labels.yaml
Lines 15 to 19 in e46577a
It looks like the Profiles Operator should also set the
user.kubeflow.org/enabled: "true"
here, for our services to properly work.The text was updated successfully, but these errors were encountered: