Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing user namespace label user.kubeflow.org/enabled #127

Closed
phoevos opened this issue Jul 12, 2023 · 2 comments · Fixed by #128 or #153
Closed

Missing user namespace label user.kubeflow.org/enabled #127

phoevos opened this issue Jul 12, 2023 · 2 comments · Fixed by #128 or #153
Assignees
Labels
23.10 Should be fixed by 23.10 bug Something isn't working

Comments

@phoevos
Copy link
Contributor

phoevos commented Jul 12, 2023

Namespaces corresponding to Kubeflow users don't get the user.kubeflow.org/enabled label required by default by the Resource Dispatcher to detect the namespaces to inject resources into.

More specifically, the Resource Dispatcher watches for newly created namespaces. If these carry a specific label (configured by the user), it injects the resources required for its related apps to work into the new namespaces. If the Resource Dispatcher is related with MLFlow, for instance, it will have to create PodDefaults and Secrets in the target namespaces to allow workloads running in them to access external services (e.g. MinIO). This label is essentially used to distinguish namespaces belonging to Kubeflow users and is set by default to user.kubeflow.org/enabled: "true".

The Profiles Operator, on the other hand, is the one that controls the labels that will end up on a new namespace, whenever a Kubeflow user Profile is created, through a YAML file pushed to the controller container. The labels currently propagated to the namespace are configured here:

katib-metricscollector-injection: "enabled"
katib.kubeflow.org/metrics-collector-injection: "enabled"
serving.kubeflow.org/inferenceservice: "enabled"
pipelines.kubeflow.org/enabled: "true"
app.kubernetes.io/part-of: "kubeflow-profile"

It looks like the Profiles Operator should also set the user.kubeflow.org/enabled: "true" here, for our services to properly work.

@phoevos phoevos added bug Something isn't working 23.10 Should be fixed by 23.10 labels Jul 12, 2023
@phoevos phoevos self-assigned this Jul 12, 2023
phoevos added a commit that referenced this issue Jul 12, 2023
Add user.kubeflow.org/enabled: "true" to the list of labels pushed to
the controller container to configure the labels added to newly created
namespaces.

Closes #127

Signed-off-by: Phoevos Kalemkeris <[email protected]>
@ca-scribner
Copy link
Contributor

For context, the resource-dispatcher can watch for any label, so we could use an existing one (maybe pipelines.kubeflow.org/enabled). But adding a new label feels cleaner as its purpose is more clear

phoevos added a commit that referenced this issue Jul 26, 2023
Add user.kubeflow.org/enabled: "true" to the list of labels pushed to
the controller container to configure the labels added to newly created
namespaces.

Closes #127

Signed-off-by: Phoevos Kalemkeris <[email protected]>
phoevos added a commit that referenced this issue Jul 26, 2023
* Add user.kubeflow.org/enabled: "true" to the list of labels pushed to
  the controller container to configure the labels added to newly created
  namespaces
* Add workflow action to save debug artifacts at the end of integrate.yaml

Closes #127

Signed-off-by: Phoevos Kalemkeris <[email protected]>
@NohaIhab
Copy link
Contributor

re-opening this because it was not fixed in track/1.7

@NohaIhab NohaIhab reopened this Sep 29, 2023
NohaIhab pushed a commit that referenced this issue Sep 29, 2023
* Add user.kubeflow.org/enabled: "true" to the list of labels pushed to
  the controller container to configure the labels added to newly created
  namespaces
* Add workflow action to save debug artifacts at the end of integrate.yaml

Closes #127

Signed-off-by: Phoevos Kalemkeris <[email protected]>
@NohaIhab NohaIhab linked a pull request Sep 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.10 Should be fixed by 23.10 bug Something isn't working
Projects
3 participants