Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charm will never recover if failed to plan on startup #117

Open
beliaev-maksim opened this issue May 23, 2023 · 2 comments
Open

charm will never recover if failed to plan on startup #117

beliaev-maksim opened this issue May 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@beliaev-maksim
Copy link
Member

If charm is freshly installed and cannot connect to the container, then it will never recover

we block the charm here and set it for waiting

raise ErrorWithStatus("Waiting for pod startup to complete", MaintenanceStatus)

however, there is no event on update status which should recover the charm

@i-chvets
Copy link
Contributor

May be it needs to be fixed this way?

if not container.can_connect():
  event.defer()
  raise ErrorWithStatus("Pod startup is not complete", MaintenanceStatus)

And then another exception?

@beliaev-maksim
Copy link
Member Author

beliaev-maksim commented May 23, 2023

@i-chvets
oh, I see what you mean

yes. Then on update status it should be deferred. That might work

@NohaIhab NohaIhab added the bug Something isn't working label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants