Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logdump action to allow using it more than once in the same CI run #95

Closed
ca-scribner opened this issue Jul 26, 2023 · 1 comment · Fixed by #111
Closed

fix logdump action to allow using it more than once in the same CI run #95

ca-scribner opened this issue Jul 26, 2023 · 1 comment · Fixed by #111
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ca-scribner
Copy link
Contributor

current logdump action dumps artifacts to a hard-coded location. This means if you run it twice (say once for each of two integration tests), they'll overwrite each other. Lets make this output configurable, or maybe by default it can introspect the job name (which will be unique) and append it to the output artifact location
@ca-scribner ca-scribner added the good first issue Good for newcomers label Jul 26, 2023
@i-chvets i-chvets added the enhancement New feature or request label Aug 16, 2023
bschimke95 added a commit to bschimke95/kubeflow-ci that referenced this issue Sep 12, 2023
@bschimke95
Make logdump action output path configurable
d18e904 
Currently, the logdump action output path is hard-coded. Running this
action twice in the same CI causes these actions to overwrite each
others logs.

With this commit, the path can now be configured by setting the
`$LOGDUMP_OUTPUT_DIR` env variable in a workflow. If it is not set
the path will fall-back to `tmp_logs_$GITHUB_JOB` with $GITHUB_JOB being
the unique id of the current running job.

Closes canonical#95
This was referenced Sep 12, 2023
Closed
Merged
@bschimke95
Copy link
Contributor

Hi @canonical/kubeflow ,

I recently joined Canonical. One of my on-boarding tasks is to fix a bug in a relevant Canonical project.

In #111 I propose a fix to make the output location of the log dump configurable. Also, if nothing is set, the action will still fall-back to a unique location facilitating the current job id.

bschimke95 added a commit to bschimke95/kubeflow-ci that referenced this issue Sep 12, 2023
@bschimke95
Make logdump action output path configurable
f85d535 
Currently, the logdump action output path is hard-coded. Running this
action twice in the same CI causes these actions to overwrite each
others logs.

With this commit, the path can now be configured by setting the
`$LOGDUMP_OUTPUT_DIR` env variable in a workflow. If it is not set
the path will fall-back to `tmp_logs_$GITHUB_JOB` with $GITHUB_JOB being
the unique id of the current running job.

Closes canonical#95
bschimke95 added a commit to bschimke95/kubeflow-ci that referenced this issue Sep 21, 2023
@bschimke95
Make logdump action output path configurable
cb299a8 
Currently, the logdump action output path is hard-coded. Running this
action twice in the same CI causes these actions to overwrite each
others logs.

With this commit, the path can now be configured by setting the
`$LOGDUMP_OUTPUT_DIR` env variable in a workflow. If it is not set
the path will fall-back to `tmp_logs_$GITHUB_JOB` with $GITHUB_JOB being
the unique id of the current running job.

Closes canonical#95
DnPlas pushed a commit that referenced this issue Sep 21, 2023
@bschimke95
Make logdump action output path configurable (#111)
f9f60e6 
Currently, the logdump action output path is hard-coded. Running this
action twice in the same CI causes these actions to overwrite each
others logs.

With this commit, the path can now be configured by setting the
`$LOGDUMP_OUTPUT_DIR` env variable in a workflow. If it is not set
the path will fall-back to `tmp_logs_$GITHUB_JOB` with $GITHUB_JOB being
the unique id of the current running job.

Closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
MLOps Solution Issues
Status: Done
Milestone
No milestone
3 participants
@ca-scribner @i-chvets @bschimke95