Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the device authorization endpoint #1

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Conversation

nsklikas
Copy link

@nsklikas nsklikas commented Feb 9, 2024

Complementary PR to canonical/fosite#2

The changes in this PR are based on the work done in ory#3252 (a lot of the work is taken unchanged).

This PR is intended to implement the logic described in paragraphs RFC8628 - Section 3.1 and RFC8628 - Section 3.1.

Future work:

  • Implement the code verify/reject endpoints (changes to the flow will be needed for this
  • Update the token endpoint
  • Implement rate limiting strategy
  • Update e2e tests

Copy link

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a bunch of generated sql migrations.. i'm sure it's ok.. just.. godocs :)

driver/config/provider.go Show resolved Hide resolved
BarcoMasile
BarcoMasile previously approved these changes Feb 12, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 19.80198% with 81 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (canonical@3e20430). Click here to learn what that means.

Files Patch % Lines
persistence/sql/persister_oauth2.go 0.00% 61 Missing ⚠️
oauth2/handler.go 6.66% 14 Missing ⚠️
fositex/config.go 33.33% 4 Missing ⚠️
driver/registry_base.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             canonical       #1   +/-   ##
============================================
  Coverage             ?   75.50%           
============================================
  Files                ?      134           
  Lines                ?    10232           
  Branches             ?        0           
============================================
  Hits                 ?     7726           
  Misses               ?     1988           
  Partials             ?      518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsklikas nsklikas merged commit 9418067 into canonical Mar 5, 2024
25 checks passed
@nsklikas nsklikas deleted the IAM-653 branch March 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants