Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCK definitions for v2.6.3 and v2.9.3. #18

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

aznashwan
Copy link
Contributor

This PR notably contains:

  • ROCK definitions for older versions for each component (v2.6.3 and v2.9.3)
  • parametrized sanity and integration tests for all rocks over all versions/architectures
  • fix for harbor-db locale issues

Notes for reviewers:

The vast majority of the older ROCKs have virtually no differences except for the source-tag of the repo being pulled, or the version of go/node snaps installed, with the only notable differences being:

  • v2.6.3/harbor-portal/rockcraft.yaml: almost completely different build steps from the later versions so worth reviewing
  • v2.6.3/harbor-db/rockcraft.yaml: only installs PostgreSQL 13, while the later versions install both 13 and 14

TODOs:

@aznashwan aznashwan requested a review from a team as a code owner July 23, 2024 14:57
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@bschimke95 bschimke95 merged commit 751ce5a into canonical:main Jul 24, 2024
14 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants