All 2.10.2 ROCKs #12
Merged
All 2.10.2 ROCKs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Harbor project has some Photon-OS based images: * docker.io/goharbor/nginx-photon:v2.10.2 * docker.io/goharbor/registry-photon:v2.10.2 * docker.io/goharbor/trivy-adapter-photon:v2.10.2 * docker.io/goharbor/redis-photon:v2.10.2 * docker.io/goharbor/harbor-portal:v2.10.2 We're defining Rock drop-in replacements, which obviously will not be Photon based. Note that the reference images have an install_cert.sh script that is a no-op on non-Photon images. We're keeping it for now, mostly for consistency.
Rockcraft does not allow two parts to stage the same files with different content. In our case, the nginx package includes a sample at /usr/share/nginx/html that has to be removed.
Signed-off-by: Nashwan Azhari <[email protected]>
Adds rockcraft specs for following core Harbor component images: * docker.io/goharbor/harbor-core:v2.10.2 * docker.io/goharbor/harbor-jobservice:v2.10.2 * docker.io/goharbor/harbor-registryctl:v2.10.2 * docker.io/goharbor/harbor-db:v2.10.2 * docker.io/goharbor/harbor-exporter:v2.10.2 Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
This was referenced Jul 18, 2024
|
Sanity tests all pass on my fork. Loose ends are:
|
bschimke95
reviewed
Jul 19, 2024
On Ubuntu 22.04 with snap installed nodejs, one of the portal dependencies fails to install: cypress-io/cypress-documentation#5868 We'll apply the recommended workaround.
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
aznashwan
force-pushed
the
all-rocks-2.10.2
branch
from
14b8514 to
6ac5a97
Compare
Signed-off-by: Nashwan Azhari <[email protected]>
|
Merging as only the upload fails (because of external contributor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the rockctaft specs and sanity tests for the following Harbor images: