Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access from stale Profiles #9

Open
kimwnasptd opened this issue Nov 26, 2024 · 1 comment
Open

Remove access from stale Profiles #9

kimwnasptd opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kimwnasptd
Copy link

Context

This is a sub-step from #8

After having an initial structure and the PMR class, the next step is to start working on the create_or_update_profiles(pmr) function. For this, the first step is to cover the logic that gets the PMR and then removes access of all contributors from this Profile.

For more information on this function please also take a look in our spec

The APs / RBs are filtered based on the user and role annotations. Only those that have both are considered "Contributor APs / RBs" and are subject to the create_or_update_profiles(pmr) function.

What needs to get done

  1. Create the module that will host the create_or_update_profiles(pmr) function
  2. Handle the logic of detecting which Profiles are stale (not in PMR)
  3. For each stale Profile, remove the contributor RoleBindings and AuthorizationPolicies

Definition of Done

  1. Have integration tests that ensures a Profile that doesn't belong to a PMR is deleted
  2. The create_or_update_profiles(pmr) function will be removing access from all stale Profiles
@kimwnasptd kimwnasptd added the enhancement New feature or request label Nov 26, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6593.

This message was autogenerated

@kimwnasptd kimwnasptd transferred this issue from canonical/bundle-kubeflow Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant