-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial structure and unit tests for PMR #7
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6592.
|
While working on this issue, I used As a north start I used the kafka-k8s-operator repo. Some critical points to expose:
|
By using To align with this, I updated the |
While working on this the CI failed on the
https://juju.is/docs/sdk/metadata-yaml This should be resolved in canonical/kubeflow-ci#148 |
Context
This is the first step for implementing the common module that handles a PMR #8
We discussed for the first iteration to include the code from the common module as part of the GitHub Automator charm and later on move it to be its own repo and PyPi module. So the first step is to submit the code alongside the charm code, and in an easy way to later on decouple from the charm.
What needs to get done
charmcraft init
the code of the charmsrc
dir, next to thecharm.py
lint
,format
,unit
,integration
) are workingThen Plan A is to have dedicated
tox
andpoetry
environments forunit-library
andintegration-library
that will encapsulate the testing of the common module.Then the
unit
andintegration
tests for the whole charm will also include the tests for the common moduleDefinition of Done
The text was updated successfully, but these errors were encountered: