Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3086] Improve CI/CD pipeline #17

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Dec 13, 2023

I noticed that in Kafka CI/CD pipeline, we have been currently publishing wrong tags, that are not according to the standard provided as company.

While fixing this, I also provided some upgrades we did in Spark rock image to:

  • make sure that versions and release branching names are consistent
  • add extra labels to the image such that we can track a bit better which code originated the image

Copy link
Contributor

@zmraul zmraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@zmraul zmraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment in zookeeper can be squeezed on this PR as well

@deusebio deusebio merged commit 66518b3 into 3-22.04 Jan 22, 2024
6 checks passed
@deusebio deusebio deleted the dpe-3086-improve-cicd branch January 22, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants