Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 1.7/stable work in an airgap environment #705

Closed
4 tasks done
DnPlas opened this issue Sep 25, 2023 · 11 comments
Closed
4 tasks done

Make 1.7/stable work in an airgap environment #705

DnPlas opened this issue Sep 25, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Sep 25, 2023

Bug Description

The goal of this task is to make the CKF 1.7/stable work in airgap environments, which means that the CKF deployment should work on an environment without internet access.

This issue will help tracking all the required changes on individual charms, as well as ensuring when integrated as a bundle, everything can be deployed and tested.

What needs to be done?

State of charms

Status State of the CI
canonical/admission-webhook-operator canonical/admission-webhook-operator#113 Green
canonical/argo-operators canonical/argo-operators#136 Green
canonical/dex-auth-operator canonical/dex-auth-operator#167 Green
canonical/istio-operators canonical/istio-operators#332 Green
canonical/katib-operators canonical/katib-operators#144 Green
canonical/kfp-operators canonical/kfp-operators#335 Green
canonical/knative-operators canonical/knative-operators#159 Green
canonical/kserve-operators canonical/kserve-operators#179 Green
canonical/kubeflow-dashboard-operator canonical/kubeflow-dashboard-operator#165 Green
canonical/kubeflow-profiles-operator canonical/kubeflow-profiles-operator#152 Green
canonical/kubeflow-roles-operator canonical/kubeflow-roles-operator#72 Green
canonical/kubeflow-tensorboards-operator canonical/kubeflow-tensorboards-operator#94 Failing to publish
canonical/kubeflow-volumes-operator canonical/kubeflow-volumes-operator#116 Green
canonical/metacontroller-operator canonical/metacontroller-operator#90 Green
canonical/minio-operator canonical/minio-operator#149 Green
canonical/notebook-operators canonical/notebook-operators#307 Green
canonical/oidc-gatekeeper-operator canonical/oidc-gatekeeper-operator#113 Green
canonical/seldon-core-operator canonical/seldon-core-operator#212 Green
canonical/training-operator canonical/training-operator#141 Green

Potential issues

#688
#690

@orfeas-k
Copy link
Contributor

Looks like knative-operator telemetry image is not configurable at the moment neither in main nor track/1.8 canonical/knative-operators#161.

@DnPlas
Copy link
Contributor Author

DnPlas commented Sep 28, 2023

Looks like knative-operator telemetry image is not configurable at the moment neither in main nor track/1.8 canonical/knative-operators#161.

These two patches should fix that:

@orfeas-k
Copy link
Contributor

Adding the note here as well that during #709, the following image 172.17.0.2:5000/knative-releases/knative.dev/serving/cmd/default-domain:2b3e4074f951dd6b6fa5018047e97a5cb10b6a6ecbb554ed77c9a8dc01011f3b was the only image (between the ones produced by the scripts) that wasn't used in the charms' configuration. We could not find a container that needs that and this is not configured in latest/edge bundle-airgap.yaml neither. This can be OK since we could fetch an image we don't need in our script. We should though keep it in the back of our minds in case we see something's off with knative-serving's deployments.
Note that I also do not see it anywhere in the serving's manifests.

@NohaIhab
Copy link
Contributor

sent a fix for kubeflow dashboard CI in canonical/kubeflow-dashboard-operator#169

@DnPlas
Copy link
Contributor Author

DnPlas commented Sep 28, 2023

Current status

Charms

All charms have been updated and are now published to their /edge tracks in Charmhub. In the case of kubeflow-tensorboards-operator the version in track/1.7 should be compatible with arigap environments.

Bundle and scripts

#709 is introducing the bundle definition for 1.7/edge airgap, but pending things to check on that PR are:

  1. The knative-operator should include the otel-collector image
  2. We have to confirm that the charm names are accurate to what is downloaded by juju in both bundle-airgap.yaml and podspec_script.sh

Testing

Not started, we can start testing after charms are published to version/edge and we update the bundle PR with the mentioned changes.
@orfeas-k to help execute these tests.

MLFLow integration

Not started, but we need to do a similar effort in the MLFlow bundle: https://github.com/canonical/mlflow-operator/blob/main/releases/2.1/edge/mlflow/bundle.yaml.

  • TBC - version of MLFlow, 2.1?
  • We have to add a bundle definition for airgap
  • We have a get-images script
  • TBC - that MLFlow images are configurable

Observability integration

Not started, TBC.

@DnPlas
Copy link
Contributor Author

DnPlas commented Sep 28, 2023

Based on a discussion with @kimwnasptd , we decided to add a "MLOps" bundle definition in this repository to help integrate with MLFlow and other charms required for a deployment with CKF and MLFlow. Please make sure you take a look at #712.

@DnPlas
Copy link
Contributor Author

DnPlas commented Sep 28, 2023

Based on a discussion with @kimwnasptd , we decided to add a "MLOps" bundle definition in this repository to help integrate with MLFlow and other charms required for a deployment with CKF and MLFlow. Please make sure you take a look at #712.

This effort is not going to be considered for this effort.

@orfeas-k
Copy link
Contributor

orfeas-k commented Sep 28, 2023

Deployed the bundle using files from PR #709 and everything went to green without issues.

Regarding the UATs, we cannot run them at the moment since they need connection to download some extra images that may not be present in the cluster at the moment and also to pip install stuff (similar reason we could not run them in self-hosted runners). Once @NohaIhab checks that UATs run successfully in a non-airgapped 1.7/edge cluster, then we could check "Test the bundle in an airgap environment" and consider this issue task.

@orfeas-k
Copy link
Contributor

I forgot to mention that during testing:

@orfeas-k
Copy link
Contributor

orfeas-k commented Oct 3, 2023

I think we could close this @DnPlas

@DnPlas
Copy link
Contributor Author

DnPlas commented Oct 16, 2023

Closing as all the required work has been completed. Thanks everyone!

@DnPlas DnPlas closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants