Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration tests for the profiles automator module #1146

Open
kimwnasptd opened this issue Nov 14, 2024 · 1 comment
Open

Create integration tests for the profiles automator module #1146

kimwnasptd opened this issue Nov 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kimwnasptd
Copy link
Contributor

Context

This is a follow-up of canonical/github-profiles-automator#8

The module will have quite a bit of edge case scenarios on how to update the KF cluster, depending on different states of the PMR. To ensure the common logic will be robust we need to ensure we have integration tests that capture a lot of the functionalities and edge case scenarios

Some of the critical functionalities we'll need to cover include:

  1. Creating new Profiles, that are defined in PMR and don't exist in the cluster
  2. Cleanup existing Profiles, if they are not defined in the PMR
  3. Create RoleBindings for a contributor in a Profile, defined in the PMR
  4. Remove a RoleBinding for a contributor in a Profile, if the contributor is not defined in the PMR

For the above we'll also need microK8s and Profile charm deployed. Also we'll need some helpers for cleaning up the Profiles between the tests.

What needs to get done

  1. Fully flesh out which tests we want to have
  2. Write code for cleaning up the profiles between test executions
  3. Create a GH action that will spin up MicroK8s, the Profiles charm and run the integration tests

Definition of Done

  1. There is a GH action that runs the integration tests
@kimwnasptd kimwnasptd added the enhancement New feature or request label Nov 14, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6550.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant