feat: get images on main #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canonical/bundle-kubeflow#679 Summary of changes: - Added script that produces list of container images managed by charm in this repository. Image list is a dynamic list. - Removed outdated get-images-1.7-stable.sh script.
18 tasks
phoevos
suggested changes
Sep 1, 2023
There was a problem hiding this comment.
Although this works on track/3.3, it breaks on main following the changes introduced here:
More specifically, running the script on main will now return:
argoproj/workflow-controller:v3.3.8
argoproj/argocli:v3.3.8
sel.model.conig[executor-image]This is to be expected, since the image is no more hardcoded in the charm, but is rather exposed as an option in the config.
BTW, it's a bit weird that we bumped the argo images in track/3.3 (to 3.3.9), but not on main.
added 3 commits
September 1, 2023 14:30
…33-feat-get-images-script-main
Summary of changes: - Updated script to get image from config.
…nical/argo-operators into kf-4233-feat-get-images-script-main
|
Updated. @phoevos please review. |
phoevos
approved these changes
Sep 2, 2023
orfeas-k
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details refer to: canonical/bundle-kubeflow#679
Summary of changes:
NOTE: Script replaced outdated get-images-1.7-stable.sh script.