From a6eaa40bed27231ffb210a8ad6558f5e5a490e74 Mon Sep 17 00:00:00 2001 From: Daniela Plascencia Date: Wed, 16 Aug 2023 18:13:51 +0200 Subject: [PATCH] fix: change default executor from pns (deprecated) to emissary (#122) The default executor in argo-controller's charm configuration is now deprecated and removed in more recent versions of argo workflows. We should consider changing the default to emissary, which is actually the default in >=3.3. Fixes #117 --- charms/argo-controller/config.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/charms/argo-controller/config.yaml b/charms/argo-controller/config.yaml index f5b2858..c32de85 100644 --- a/charms/argo-controller/config.yaml +++ b/charms/argo-controller/config.yaml @@ -12,10 +12,11 @@ options: description: S3 key prefix executor: type: string - default: pns + default: emissary description: | - Runtime executor for workflow containers. Cannot be `docker` on containerd, - for a full list of executors, see https://github.com/argoproj/argo/tree/master/workflow/executor + Runtime executor for workflow containers. Defaults to `emissary` as it is the default in both Argo Workflows and + the upstream Kubeflow project. Cannot be `docker` on containerd, for a full list of executors, see: + https://argoproj.github.io/argo-workflows/workflow-executors/#workflow-executors executor-image: type: string default: argoproj/argoexec:v3.3.9