Skip to content

Commit

Permalink
fix: change default executor from pns (deprecated) to emissary (#122)
Browse files Browse the repository at this point in the history
The default executor in argo-controller's charm configuration is now deprecated and removed in more recent versions of argo workflows. We should consider changing the default to emissary, which is actually the default in >=3.3.

Fixes #117
  • Loading branch information
DnPlas authored and orfeas-k committed Sep 26, 2023
1 parent 92affde commit a6eaa40
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions charms/argo-controller/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ options:
description: S3 key prefix
executor:
type: string
default: pns
default: emissary
description: |
Runtime executor for workflow containers. Cannot be `docker` on containerd,
for a full list of executors, see https://github.com/argoproj/argo/tree/master/workflow/executor
Runtime executor for workflow containers. Defaults to `emissary` as it is the default in both Argo Workflows and
the upstream Kubeflow project. Cannot be `docker` on containerd, for a full list of executors, see:
https://argoproj.github.io/argo-workflows/workflow-executors/#workflow-executors
executor-image:
type: string
default: argoproj/argoexec:v3.3.9
Expand Down

0 comments on commit a6eaa40

Please sign in to comment.