Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logos to be properly cropped #311

Merged
merged 1 commit into from
Sep 14, 2023
Merged

update logos to be properly cropped #311

merged 1 commit into from
Sep 14, 2023

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Aug 28, 2023

Done

  • update vanilla
  • update logos for the parter section

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8043/
  • Run through the following QA steps
  • check the logo section on the start page

@webteam-app
Copy link

Demo starting at https://anbox-cloud-io-311.demos.haus

@edlerd edlerd marked this pull request as ready for review September 13, 2023 15:59
lorumic
lorumic approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good, I just have one unimportant question about the AWS logo, but apart from that I think we're ready to go.

templates/index.html Show resolved Hide resolved
@edlerd edlerd merged commit 18ef191 into canonical:main Sep 14, 2023
6 checks passed
@edlerd edlerd deleted the update-logos branch September 14, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @lorumic