-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent defining with a string #2
Comments
We do want to support constructors, right? At least for built-ins like |
Yeah maybe. I know we want something like: class Person extends DefineClass {
static define = {
name: types(String)
}
} Accepting constructors (functions) would prevent us from having a different meaning of passing a function in the future though. |
Will do this after #3 |
Will it be confusing if we support: class Person extends DefineClass {
static define = {
name: String
}
} But not: class Thing extends DefineClass {
static define = {
prop: MyCustomClass
}
} ? To me that is slightly confusing |
This is done in #50. Strings are now default values like other primitives. |
This will not be supported at first:
We should not allow:
The text was updated successfully, but these errors were encountered: