Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete proxy trap not implemented #110

Open
matthewp opened this issue Jul 12, 2019 · 2 comments
Open

delete proxy trap not implemented #110

matthewp opened this issue Jul 12, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@matthewp
Copy link
Contributor

Observations occur when:

object.foo = undefined;

But not when:

delete object[foo];

occurs. Probably just need to add some ObservationRecorder.adds?

@phillipskevin
Copy link
Contributor

Probably just needs to dispatch an event similar to set.

@matthewp
Copy link
Contributor Author

Actually this can't easily be implemented. define() sets up property descriptors, and therefore delete foo.bar will not hit the proxy trap. You'd have to add another proxy on the instance itself, I think.

@chasenlehara chasenlehara added the bug Something isn't working label Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants