Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration should be primarily through application.yaml and not environment variables #604

Open
Tracked by #1
jessesimpson36 opened this issue Apr 10, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jessesimpson36
Copy link
Contributor

jessesimpson36 commented Apr 10, 2024

Currently, we configure the applications via env vars.
We should move to application config like what we did in Helm (here is an example for Optimize)

Most, if not all, env vars follow the Sprint Boot convention, so SPRING_CONFIG_NAME=xyz represents the following YAML:

spring:
  config:
    name: xyz

Just be careful of how entry point scripts may alter env vars, like Zeebe entry point altering ZEEBE_GATEWAY_NETWORK_HOST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants