Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): disable core client secret if identity is disabled #2584

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(core): disable core client secret if identity is disabled #2584

merged 1 commit into from
Nov 18, 2024

Conversation

aabouzaid
Copy link
Member

Which problem does the PR fix?

Related to: #2525

What's in this PR?

Disable core client secret en var if identity is disabled.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid added the size/xs Relative effort/time: Extra Small label Nov 18, 2024
@aabouzaid aabouzaid requested a review from a team November 18, 2024 18:05
@aabouzaid aabouzaid self-assigned this Nov 18, 2024
@aabouzaid aabouzaid mentioned this pull request Nov 18, 2024
Closed
@aabouzaid aabouzaid marked this pull request as ready for review November 18, 2024 18:06
@aabouzaid aabouzaid merged commit 89a1333 into main Nov 18, 2024
13 checks passed
@aabouzaid aabouzaid deleted the 2525-fix-core-token-var branch November 18, 2024 18:15
@distro-ci distro-ci bot mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aabouzaid aabouzaid

Labels
size/xs Relative effort/time: Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aabouzaid