Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix missing newline #2571

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style: fix missing newline #2571

wants to merge 2 commits into from

Conversation

vthiery
Copy link
Member

@vthiery vthiery commented Nov 15, 2024

Which problem does the PR fix?

When installing, the doc reads:

> kubectl port-forward svc/camunda-platform-zeebe-gateway 26500:26500 -n default
> kubectl port-forward svc/camunda-platform-zeebe-gateway 8088:8080 -n default

Now you can connect your workers and clients to `localhost:26500`
### Connecting to Web apps


As part of the Helm charts, an ingress definition can be deployed, but you require to have an Ingress Controller for that Ingress to be Exposed.

What's in this PR?

A simple Go template change to keep left space before the new section.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?
    • No, but the failures are unlikely the result of this change

@vthiery vthiery marked this pull request as ready for review November 15, 2024 11:58
@vthiery vthiery requested a review from a team November 15, 2024 11:59
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙌
Please rebase your branch to the latest main to fix the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants