Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment configuration with authentication options #741

Closed
tewald opened this issue Feb 22, 2018 · 8 comments
Closed

Deployment configuration with authentication options #741

tewald opened this issue Feb 22, 2018 · 8 comments
Assignees
Labels
deploy enhancement New feature or request
Milestone

Comments

@tewald
Copy link

tewald commented Feb 22, 2018

Hi!

I'm using the dev version, testing the deploy functionality, and it works as expected.
But here our camunda rest API has a filter that uses JWT to set user and tenantId for the request.
So, to make it work, I added the Authentication header, with the bearer token, and it's all good again.
I think it should be nice to set some auth options, like in Insomnia REST client, for example.
I'm hacking some code here to add at least basic and token auth options to the configuration modal.

My JS-foo is not the strongest, but I did manage to do something like this:
no
basic
bearer

What are you thoughts?

(On a side note, it could be nice to also load the diagrams from the rest api, making the modeler a full-online tool for camunda)

Thanks!
Thomas

@nikku
Copy link
Member

nikku commented Feb 22, 2018

Hey @tewald. Could file a PR adding the changes?

We're still in the process of discussing which authentication options to offer, especially given that we (Camunda) don't impose any constraints to our users.

The two options you provide seem like two popular ones to go for.

@nikku nikku added enhancement New feature or request backlog Queued in backlog labels Feb 22, 2018
tewald added a commit to catallog/camunda-modeler that referenced this issue Feb 22, 2018
@ghost ghost added needs review Review pending and removed backlog Queued in backlog labels Feb 22, 2018
@tewald
Copy link
Author

tewald commented Feb 22, 2018

OK, my fault.
I'll fix the CI errors. :-(

tewald added a commit to catallog/camunda-modeler that referenced this issue Feb 22, 2018
@nikku nikku added the deploy label Feb 22, 2018
@nikku
Copy link
Member

nikku commented Feb 28, 2018

Thanks for the PR. We'll merge it with one of our next releases.

@nikku nikku added ready Ready to be worked on and removed needs review Review pending labels Feb 28, 2018
@nikku nikku added this to the M19 milestone Feb 28, 2018
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Mar 6, 2018
@nikku nikku modified the milestones: M19, M20 Mar 23, 2018
@romansmirnov romansmirnov removed this from the M20 milestone Apr 3, 2018
@XDracam
Copy link

XDracam commented Oct 30, 2018

What's the state of this?
We would like to serve a custom endpoint for uploading diagrams using basic auth so that we can do some further diagram validation.

@volodya327
Copy link

Hi, Comunity is still waiting for this fix. Could you tell me, please, about your plans/future relases ?

@nikku
Copy link
Member

nikku commented Nov 23, 2018

We cannot promise an exact availability date of this feature but rest assured this will land in one of the next Camunda Modeler releases.

@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Nov 23, 2018
@nikku nikku added this to the M26 milestone Nov 23, 2018
@ghost ghost assigned barmac Dec 3, 2018
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Dec 3, 2018
barmac added a commit that referenced this issue Dec 6, 2018
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Dec 6, 2018
nikku pushed a commit that referenced this issue Dec 10, 2018
nikku pushed a commit that referenced this issue Dec 10, 2018
nikku pushed a commit that referenced this issue Dec 10, 2018
nikku pushed a commit that referenced this issue Dec 11, 2018
@nikku
Copy link
Member

nikku commented Dec 11, 2018

Integrated your work into the next branch. Our upcoming modeler will feature deployment against authenticated engines 🎉.

screely-1544532777363

@nikku
Copy link
Member

nikku commented Dec 11, 2018

Closed via #906.

@nikku nikku closed this as completed Dec 11, 2018
@ghost ghost removed the needs review Review pending label Dec 11, 2018
nikku pushed a commit that referenced this issue Dec 11, 2018
barmac added a commit that referenced this issue Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants