Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"appendElement is not a registered action" with new context pad #4349

Closed
barmac opened this issue Jun 6, 2024 · 4 comments
Closed

"appendElement is not a registered action" with new context pad #4349

barmac opened this issue Jun 6, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Jun 6, 2024

Describe the bug

The new context pad broke the "A" shortcut for create anything. The following error is reported:

appendElement is not a registered action
    at s (webpack://camundanode_modules/diagram-js/lib/features/editor-actions/EditorActions.js:266:9)
    at error (webpack://camundanode_modules/diagram-js/lib/features/editor-actions/EditorActions.js:175:10)
    at trigger (webpack://camunda-modeler-client/src/app/tabs/cloud-bpmn/BpmnEditor.js:709:40)
    at triggerAction (webpack://camunda-modeler-client/src/app/tabs/MultiSheetTab.js:269:18)
    at triggerAction (webpack://camunda-modeler-client/src/app/tabs/EditorTab.js:36:33)
    at file:///Users/maciej/Desktop/rc/Camunda%20Modeler%202.app/Contents/Resources/app.asar/public/bundle.js:2:3598876
    at fn (webpack://camunda-modeler-client/src/app/App.js:2448:19)
    at file:///Users/maciej/Desktop/rc/Camunda%20Modeler%202.app/Contents/Resources/app.asar/public/bundle.js:2:3603414
    at exec (webpack://camunda-modeler-client/src/app/AppParent.js:76:11)
    at onAction (webpack://camunda-modeler-client/src/app/KeyboardBindings.js:161:6) [ error ]

Steps to reproduce

  1. Enable flag for the new context pad
  2. Press "A"
  3. now this happens

Expected behavior

No error is reported and create anything menu opens

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: v5.24.0
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: --enable-new-context-pad

Additional context

No response

@barmac barmac added the bug Something isn't working label Jun 6, 2024
@philippfromme
Copy link
Contributor

Note that this error only occurs in the Desktop Modeler. It works in @camunda/improved canvas and in the web modeler.

@nikku nikku added the ready Ready to be worked on label Jun 13, 2024
@nikku
Copy link
Member

nikku commented Jun 13, 2024

Let's investigate this and potentially fix as a minor follow-up. Moving to ready.

@barmac
Copy link
Collaborator Author

barmac commented Jun 27, 2024

In the improved-canvas library, we register appendCreatePad action, and deregister appendElement. Somehow the latter action is still kept for the keyboard binding though.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 27, 2024
@nikku
Copy link
Member

nikku commented Jul 1, 2024

Closed via #4408.

@nikku nikku closed this as completed Jul 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 1, 2024
@github-actions github-actions bot added this to the M79 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants