Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify class management and change of density value formats #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify class management and change of density value formats #59

wants to merge 1 commit into from

Conversation

jgarciahospital
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction
  • enhancement/feature

What this PR does / why we need it:

Including proposal of solution for:
#56 Mapping of enum and classes in densitydata & simplify class CellPopulationDensityData
#58 Integer value format for population density values

Which issue(s) this PR fixes:

Fixes #56 #58

@jgarciahospital
Copy link
Collaborator Author

jgarciahospital commented Nov 25, 2024 •
edited
Loading

@bigludo7 please for your review

Consider the change in the schemas to validate if this proposal is ok for you, compared with a alternative:

 propertyName: dataType
        mapping:
          NO_DATA: '#/components/schemas/NoDataPopulationDensityData'
          LOW_DENSITY: '#/components/schemas/LowDensityPopulationDensityData'
          DENSITY_ESTIMATION: '#/components/schemas/DensityEstimationPopulationDensityData'

Conscious that in other APIs the mapping is no so strict, e.g. https://github.com/camaraproject/DeviceLocation/blob/main/code/API_definitions/location-retrieval.yaml#L310
https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml

@bigludo7
Copy link
Collaborator

Hello @jgarciahospital
Work for me !
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigludo7 bigludo7 Awaiting requested review from bigludo7

@sachinvodafone sachinvodafone Awaiting requested review from sachinvodafone sachinvodafone is a code owner

@maheshc01 maheshc01 Awaiting requested review from maheshc01 maheshc01 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the API more developer friendly
2 participants
@jgarciahospital @bigludo7