Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is x-correlator support required at OIDC endpoints? #240

Open
trehman-gsma opened this issue Dec 2, 2024 · 1 comment
Open

Is x-correlator support required at OIDC endpoints? #240

trehman-gsma opened this issue Dec 2, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@trehman-gsma
Copy link
Collaborator

trehman-gsma commented Dec 2, 2024

Context
The CAMARA APIs define 401 and 403 error responses that include an optional x-correlator header. For example, in SimSwap v1.0.0 and CAMARA_common.yaml r0.4.0. In architectures where the AZ validates the request before it reaches the service API, x-correlator support may be required at the AZ level.

Questions

  • Is x-correlator support required at all OIDC endpoints (e.g. GET /auth, POST /bc-authorize, POST /token)?
  • Should the ICM documentation make a note about expected x-correlator behaviour for 401/403 service API responses?
@trehman-gsma trehman-gsma added the documentation Improvements or additions to documentation label Dec 2, 2024
@jpengar
Copy link
Collaborator

jpengar commented Dec 3, 2024

CAMARA defines the x-correlator header for CAMARA APIs calls as per https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#9-architecture-headers.

However, the authentication flows follow the OAuth/OIDC/CIBA standards and have their own interface definitions, errors, headers, etc. I see no reason for ICM to require x-correlator header for the authentication flows endpoints just because it is defined for CAMARA APIs requests/responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants