From 2598420ea8c0fdc2753821ff7a4c196f8c786a24 Mon Sep 17 00:00:00 2001 From: Kevin Smith Date: Thu, 16 May 2024 15:56:52 +0100 Subject: [PATCH 1/4] Proposed text for 'Guidance for closing issues' Fixes #136 --- CONTRIBUTING.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 448e0c9f..e8b78fce 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -28,6 +28,16 @@ If you have questions about one of the issues, please comment on them, and one o Please provide as much context as possible when you open an issue. The information you provide must be comprehensive enough to reproduce that issue for the assignee. Therefore, contributors may use but aren't restricted to the issue template provided by the project maintainers. +### Guidance for closing issues +* As per the [ProjectCharter](https://github.com/camaraproject/Governance/blob/5fc802713d71a51da64136f692b16ed620eeffa5/ProjectCharter.md), The default decision making mechanism for the CAMARA Project is [lazy consensus](https://couchdb.apache.org/bylaws.html#lazy). This means that any decision on technical issues is considered supported by the team as long as nobody objects based on substantiated technical grounds. +* Once consensus is achieved, an issue may be closed by the original author or by a maintainer in the sub-project. +* Closing an issue should include a comment on how it was resolved, or reference to consensus that the issue can not be resolved. +* Issues that are considered stale/inactive may be closed, but must include a reference to minutes where it has been agreed to be a stale issue. +* Maintainers may not close their own issues without reference to consensus achieved. +* A sub-project participant may object to closure of an issue if they believe consensus was not reached, in which case they may reopen the issue, stating they believe consensus has not been reached. +* Closure of an issue may require closure of a Pull Request which only fixed that single (now closed) issue. + + ## Contributing Code You are welcome to contribute code in order to fix a bug or to implement a new feature. From 81d873f21edf62292b32b20648de9ebc76d69f27 Mon Sep 17 00:00:00 2001 From: Kevin Smith Date: Tue, 4 Jun 2024 11:21:22 +0100 Subject: [PATCH 2/4] Update CONTRIBUTING.md Herbert's amendment Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e8b78fce..dfbf41c1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,7 +31,7 @@ Please provide as much context as possible when you open an issue. The informati ### Guidance for closing issues * As per the [ProjectCharter](https://github.com/camaraproject/Governance/blob/5fc802713d71a51da64136f692b16ed620eeffa5/ProjectCharter.md), The default decision making mechanism for the CAMARA Project is [lazy consensus](https://couchdb.apache.org/bylaws.html#lazy). This means that any decision on technical issues is considered supported by the team as long as nobody objects based on substantiated technical grounds. * Once consensus is achieved, an issue may be closed by the original author or by a maintainer in the sub-project. -* Closing an issue should include a comment on how it was resolved, or reference to consensus that the issue can not be resolved. +* Closing an issue should include a comment on how it was resolved or why it won't be resolved * Issues that are considered stale/inactive may be closed, but must include a reference to minutes where it has been agreed to be a stale issue. * Maintainers may not close their own issues without reference to consensus achieved. * A sub-project participant may object to closure of an issue if they believe consensus was not reached, in which case they may reopen the issue, stating they believe consensus has not been reached. From efb1f84cbecb1acd43a7af1dc2576c75b4e18557 Mon Sep 17 00:00:00 2001 From: Kevin Smith Date: Tue, 4 Jun 2024 15:15:29 +0100 Subject: [PATCH 3/4] Update CONTRIBUTING.md Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dfbf41c1..b19adf06 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,7 +30,7 @@ Please provide as much context as possible when you open an issue. The informati ### Guidance for closing issues * As per the [ProjectCharter](https://github.com/camaraproject/Governance/blob/5fc802713d71a51da64136f692b16ed620eeffa5/ProjectCharter.md), The default decision making mechanism for the CAMARA Project is [lazy consensus](https://couchdb.apache.org/bylaws.html#lazy). This means that any decision on technical issues is considered supported by the team as long as nobody objects based on substantiated technical grounds. -* Once consensus is achieved, an issue may be closed by the original author or by a maintainer in the sub-project. +* Once consensus is achieved, an issue may be closed by the original author or by a maintainer in the sub-project (if not closed by a Pull Request merge, where the issue is linked as getting fixed, see below) * Closing an issue should include a comment on how it was resolved or why it won't be resolved * Issues that are considered stale/inactive may be closed, but must include a reference to minutes where it has been agreed to be a stale issue. * Maintainers may not close their own issues without reference to consensus achieved. From 8e14fa4b545bc98d25801623521f63e8a0a11ce4 Mon Sep 17 00:00:00 2001 From: Kevin Smith Date: Tue, 4 Jun 2024 17:17:49 +0100 Subject: [PATCH 4/4] Update CONTRIBUTING.md Update following Conversation comments --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b19adf06..573408bd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,8 +32,8 @@ Please provide as much context as possible when you open an issue. The informati * As per the [ProjectCharter](https://github.com/camaraproject/Governance/blob/5fc802713d71a51da64136f692b16ed620eeffa5/ProjectCharter.md), The default decision making mechanism for the CAMARA Project is [lazy consensus](https://couchdb.apache.org/bylaws.html#lazy). This means that any decision on technical issues is considered supported by the team as long as nobody objects based on substantiated technical grounds. * Once consensus is achieved, an issue may be closed by the original author or by a maintainer in the sub-project (if not closed by a Pull Request merge, where the issue is linked as getting fixed, see below) * Closing an issue should include a comment on how it was resolved or why it won't be resolved -* Issues that are considered stale/inactive may be closed, but must include a reference to minutes where it has been agreed to be a stale issue. -* Maintainers may not close their own issues without reference to consensus achieved. + + * A sub-project participant may object to closure of an issue if they believe consensus was not reached, in which case they may reopen the issue, stating they believe consensus has not been reached. * Closure of an issue may require closure of a Pull Request which only fixed that single (now closed) issue.